JoaoJandre commented on PR #7446: URL: https://github.com/apache/cloudstack/pull/7446#issuecomment-1806284537
> @JoaoJandre I tested the PR, the feature works in general, and it's good. However, I encountered the below scenarios that need to be reviewed and discussed. > > 1. Moving a domain to a parent domain with no resource limit i.e unlimited doesn't work. There appears to be something wrong with the implementation. > > > ``` > (MoveDomainPR) 🐱 > move domain domainid=010957cd-4388-4ba0-a18d-d5df0814ad06 parentdomainid=41928b19-adf8-4524-8ca6-16d395a1136c > 🙈 Error: (HTTP 535, error code 4370) Cannot move domain [010957cd-4388-4ba0-a18d-d5df0814ad06] to parent domain [41928b19-adf8-4524-8ca6-16d395a1136c] as maximum domain resource limit of type [user_vm] would be exceeded. The current resource count for domain [010957cd-4388-4ba0-a18d-d5df0814ad06] is [0], the resource count for the new parent domain [41928b19-adf8-4524-8ca6-16d395a1136c] is [0], and the limit is [-1]. > ``` > > `https://github.com/scclouds/cloudstack/blob/029164cb1d33b92ece6a9557fb514b490988d1a0/server/src/main/java/com/cloud/user/DomainManagerImpl.java#L981C12-L981C108` > > 2. I am able to move a domain while there are resources deployed on a cluster dedicated to the previous parent domain. Further start operation and new deployment fails as it is the only cluster in the zone. This doesn't seem ideal. > > 3. Move with instance created from computer offering dedicated to parent domain : This is currently allowed but not sure whether it should be allowed. On Clicking the Compute offering (from instance details) after moving the domain we get 404. > > 4. Move domain with instances deployed to network created from network offering dedicated to parent domain: This is currently allowed but not sure whether it should be allowed. On Clicking the Network offering (from network details) after moving the domain we get 404. > > > cc @harikrishna-patnala @rajujith thanks for testing, I'll try to address your comments next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
