vishesh92 commented on code in PR #7659:
URL: https://github.com/apache/cloudstack/pull/7659#discussion_r1392760554
##########
framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java:
##########
@@ -907,6 +907,15 @@ public T findOneBy(SearchCriteria<T> sc) {
return findOneIncludingRemovedBy(sc);
}
+ @Override
+ @DB()
+ public T findOneBy(SearchCriteria<T> sc, final Filter filter) {
Review Comment:
Since we are fetching results including removed entries, this should be
renamed as `findOneIncludingRemovedBy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
