BryanMLima commented on code in PR #7659:
URL: https://github.com/apache/cloudstack/pull/7659#discussion_r1392788241


##########
framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java:
##########
@@ -907,6 +907,15 @@ public T findOneBy(SearchCriteria<T> sc) {
         return findOneIncludingRemovedBy(sc);
     }
 
+    @Override
+    @DB()
+    public T findOneBy(SearchCriteria<T> sc, final Filter filter) {

Review Comment:
   @vishesh92 we are fetching only non-removed entries here, and the method in 
line 915 does not limit to one result, as I need. The other method I could use 
is `findOneBy(final SearchCriteria<T> sc)`, however, I cannot pass an already 
created filter. That's why I created this method, as I needed to order the 
results by the `created` column, and limit to only one result. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to