weizhouapache commented on PR #7150: URL: https://github.com/apache/cloudstack/pull/7150#issuecomment-1816449820
> > > @BryanMLima , one last thing; Do you think it makes sense to add the integration test to the test matrix somewhere? (in .github/workflows/ci.yaml) > > > > > > To be honest, I do not know the criteria for adding integration tests to the test matrix. From my understanding, all smoke tests need to pass for a PR to be merged, thus, I do not think it is necessary to add the integration test to the test matrix as well. > > @BryanMLima, adding it to the github actions matrix will give a result without waiting for shapeblue people. And as this is a no hardware required test it could well be executed in the simulator as well. As you say "not .. necessary" but convenient for reviewing and keeping the feature safe. ah, ok, sometimes smoke tests pass in trillian test but not in CI tests. we can have a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
