weizhouapache commented on code in PR #8247:
URL: https://github.com/apache/cloudstack/pull/8247#discussion_r1397478425
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3979,7 +3979,8 @@ private DiskDef.DiskBus getGuestDiskModel(final String
platformEmulator, boolean
return DiskDef.DiskBus.SCSI;
} else if (platformEmulator.contains("Ubuntu") ||
StringUtils.startsWithAny(platformEmulator,
- "Fedora", "CentOS", "Red Hat Enterprise Linux",
"Debian GNU/Linux", "FreeBSD", "Oracle", "Other PV")) {
+ "Fedora", "CentOS", "Red Hat Enterprise Linux",
"Debian GNU/Linux", "FreeBSD", "Oracle",
+ "Rocky", "AlmaLinux", "Other PV")) {
Review Comment:
Actually I was thinking about changing AlmaLinux to Alma. :-D
Since users are able to add new guest OS and mappings. Is it possible that
the new guest OS does not start with "Rocky Linux" or "AlmaLinux", for
example, "Rocky 10" or "Alma Linux 10" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
