DaanHoogland commented on code in PR #8247:
URL: https://github.com/apache/cloudstack/pull/8247#discussion_r1398189682
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3979,7 +3979,8 @@ private DiskDef.DiskBus getGuestDiskModel(final String
platformEmulator, boolean
return DiskDef.DiskBus.SCSI;
} else if (platformEmulator.contains("Ubuntu") ||
StringUtils.startsWithAny(platformEmulator,
- "Fedora", "CentOS", "Red Hat Enterprise Linux",
"Debian GNU/Linux", "FreeBSD", "Oracle", "Other PV")) {
+ "Fedora", "CentOS", "Red Hat Enterprise Linux",
"Debian GNU/Linux", "FreeBSD", "Oracle",
+ "Rocky", "AlmaLinux", "Other PV")) {
Review Comment:
I am convinced and would not change it, though with your argument "Rocky",
"Alma" makes sense. I was asking because we recently made the version and
hypervisor string improvement that led to the "Red" vs. "Red Hat Enterprise
Linux" discrepency. We still use that one here. I have no strong opinion as
long as it works ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
