winterhazel opened a new pull request, #8264: URL: https://github.com/apache/cloudstack/pull/8264
### Description When HTTP is used to upload volumes, templates and ISOs (configuration `use.https.to.upload` is set to `false`), an error occurs during the validation of the request's signature, preventing uploads from finishing successfully. This happens because an URL in the format `String fullUrl = "https://"; + hostname + "/upload/" + uuid` is always created for the validation whether HTTP or HTTPS was being used. This PR addresses this issue, allowing users to upload volumes, templates and ISOs through HTTP. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? First, before applying the changes, I set `use.https.to.upload` to `false` and recreated the SSVM. Then, through the UI: 1. I tried to upload a template and verified that the signature validation failed; 2. I tried to upload an ISO and verified that the signature validation failed; 3. I tried to upload a volume and verified that the signature validation failed. I applied the changes and, with `use.https.to.upload` still set to `false`, I recreated the SSVM. Then, through the UI: 1. I tried to upload a template and verified that the upload finished successfully; 2. I tried to upload an ISO and verified that the upload finished successfully; 3. I tried to upload a volume and verified that the upload finished successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
