rp- commented on code in PR #8271:
URL: https://github.com/apache/cloudstack/pull/8271#discussion_r1406523218
##########
plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/util/LinstorConfigurationManager.java:
##########
@@ -21,8 +21,8 @@
public class LinstorConfigurationManager implements Configurable
{
- public static final ConfigKey<Boolean> BackupSnapshots = new
ConfigKey<>(Boolean.class, "lin.backup.snapshots", "Advanced", "false",
- "Backup Linstor primary storage snapshots to secondary storage
(deleting ps snapshot), only works on hyperconverged setups.", true,
ConfigKey.Scope.Global, null);
+ public static final ConfigKey<Boolean> BackupSnapshots = new
ConfigKey<>(Boolean.class, "lin.backup.snapshots", "Advanced", "true",
Review Comment:
a) This setting wasn't in any official release yet.
b) The default expected behavior of CloudStack is IMHO that snapshots are
backup'ed to secondary storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
