nvazquez commented on code in PR #8189:
URL: https://github.com/apache/cloudstack/pull/8189#discussion_r1415913781
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -2863,7 +2862,7 @@ private Network createGuestNetwork(final long
networkOfferingId, final String na
// Check if cidr is RFC1918 compliant if the network is Guest Isolated
for IPv4
if (cidr != null && ntwkOff.getGuestType() ==
Network.GuestType.Isolated && ntwkOff.getTrafficType() == TrafficType.Guest) {
- if (!NetUtils.validateGuestCidr(cidr)) {
+ if (!ConfigurationManager.AllowNonRFC1918CompliantIPs.value() &&
!NetUtils.validateGuestCidr(cidr)) {
Review Comment:
So if the setting is true we dont validate the guest CIDR? I think we need
to refactor this condition
##########
plugins/integrations/kubernetes-service/src/main/resources/conf/k8s-control-node-add.yml:
##########
@@ -259,6 +259,7 @@ write_files:
runcmd:
- chown -R cloud:cloud /home/cloud/.ssh
+ - ip link set dev eth0 mtu 1400
Review Comment:
Also this one
##########
plugins/integrations/kubernetes-service/src/main/resources/conf/k8s-control-node.yml:
##########
@@ -320,6 +320,7 @@ write_files:
runcmd:
- chown -R cloud:cloud /home/cloud/.ssh
+ - ip link set dev eth0 mtu 1400
Review Comment:
Should we keep this as a general step?
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java:
##########
@@ -645,4 +663,76 @@ private List<NsxLoadBalancerMember>
getLoadBalancerMembers(LoadBalancingRule lbR
}
return lbMembers;
}
+
+ @Override
+ public boolean applyNetworkACLs(Network network, List<? extends
NetworkACLItem> rules) throws ResourceUnavailableException {
Review Comment:
I think these methods are already merged on the nsx-integration branch,
maybe we need to rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
