Pearl1594 commented on code in PR #8189:
URL: https://github.com/apache/cloudstack/pull/8189#discussion_r1415925691
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -2863,7 +2862,7 @@ private Network createGuestNetwork(final long
networkOfferingId, final String na
// Check if cidr is RFC1918 compliant if the network is Guest Isolated
for IPv4
if (cidr != null && ntwkOff.getGuestType() ==
Network.GuestType.Isolated && ntwkOff.getTrafficType() == TrafficType.Guest) {
- if (!NetUtils.validateGuestCidr(cidr)) {
+ if (!ConfigurationManager.AllowNonRFC1918CompliantIPs.value() &&
!NetUtils.validateGuestCidr(cidr)) {
Review Comment:
I'll add a check to validate cidr.. but not validate the compliance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
