DaanHoogland commented on code in PR #8312:
URL: https://github.com/apache/cloudstack/pull/8312#discussion_r1417397935


##########
plugins/backup/networker/src/test/java/org/apache/backup/networker/NetworkerClientTest.java:
##########
@@ -60,6 +63,15 @@ public void setUp() throws Exception {
         client = new NetworkerClient(url, adminUsername, adminPassword, false, 
60);
     }
 
+    private int getRandomPort() {

Review Comment:
   I think we should not do this. let's keep it deterministic.



##########
plugins/backup/networker/src/test/java/org/apache/backup/networker/NetworkerClientTest.java:
##########
@@ -60,6 +63,15 @@ public void setUp() throws Exception {
         client = new NetworkerClient(url, adminUsername, adminPassword, false, 
60);
     }
 
+    private int getRandomPort() {

Review Comment:
   I think we should not do this. let's keep it deterministic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to