Re: [PR] CKS: provision LoadBalancerRule if vpc tier supports conserve mode [cloudstack]

Wed, 06 Dec 2023 16:10:13 -0800 


Pearl1594 commented on code in PR #8308:
URL: https://github.com/apache/cloudstack/pull/8308#discussion_r1418145184


##########
ui/src/views/network/PublicIpResource.vue:
##########
@@ -136,17 +146,22 @@ export default {
         // VPC IPs don't have firewall
         let tabs = this.$route.meta.tabs.filter(tab => tab.name !== 'firewall')
 
+        if (this.resource.networkofferingconservemode) {
+          this.tabs = tabs

Review Comment:
   Seems like resource doesn't have networkofferingconservemode field:
   ```
   
![image](https://github.com/apache/cloudstack/assets/10495417/f17403c0-3abf-4c83-8211-268a56ebc14e)
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to