Pearl1594 commented on code in PR #8308:
URL: https://github.com/apache/cloudstack/pull/8308#discussion_r1418141719
##########
ui/src/views/network/PublicIpResource.vue:
##########
@@ -136,17 +146,22 @@ export default {
// VPC IPs don't have firewall
let tabs = this.$route.meta.tabs.filter(tab => tab.name !== 'firewall')
+ if (this.resource.networkofferingconservemode) {
+ this.tabs = tabs
+ return
+ }
+
this.portFWRuleCount = await this.fetchPortFWRule()
this.loadBalancerRuleCount = await this.fetchLoadBalancerRule()
// VPC IPs with PF only have PF
if (this.portFWRuleCount > 0) {
- tabs = this.defaultTabs.concat(this.$route.meta.tabs.filter(tab =>
tab.name === 'portforwarding'))
+ tabs = tabs.filter(tab => tab.name !== 'loadbalancing')
Review Comment:
Not sure if this is required. Because for conserve mode, we have public IP
having both LB and PF rule setup, so it doesn't display both tabs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
