weizhouapache commented on issue #8352: URL: https://github.com/apache/cloudstack/issues/8352#issuecomment-1853695573
> @shwstppr, it fails [here](https://github.com/apache/cloudstack/pull/6699/files#diff-cf68e132ad7711cfa9250cda5819c09f51cba9933aa595cd82ad5a02b4edbe64R899) when trying to create URI from the URL string > > > ``` > > public static UriInfo getUriInfo(String url) { > > try { > > if (url == null) { > > return new UriInfo(); > > } > > if (url.startsWith("rbd://")) { > > return getRbdUrlInfo(url); > > } > > URI uri = new URI(UriUtils.encodeURIComponent(url)); > > return new UriInfo(uri.getScheme(), uri.getHost(), uri.getPath(), uri.getUserInfo(), uri.getPort()); > > } catch (URISyntaxException e) { > > throw new CloudRuntimeException(url + " is not a valid uri"); > > } > > } > > ``` @slavkap this code block already exists in 4.18.1.0 #6792 #7708 did you face any problem in 4.18.1.0 ? If not, I think there is no issue with this code block. The problem might be caused by the value passed `cmd.getUrl()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
