BryanMLima commented on PR #8350:
URL: https://github.com/apache/cloudstack/pull/8350#issuecomment-1853969785

   @DaanHoogland @havengit, the default global configuration values should only 
be used as a guideline, and it will not work in every environment.
   
   This feature was introduced in PR #5984 with the configuration 
`vm.stats.max.retention.time` with value of `1` (to maintain backward 
compatibility), which would not cause any problems, performance-wise. However, 
the default value was changed to `720` with PR #6803, which seems to be too 
high for larger environments. I do not think that changing the default value 
again is going to help anybody. Documentation regarding the combination of the 
parameters `vm.stats.max.retention.time` and `vm.stats.interval` would benefit 
everyone. IMHO, the default value `vm.stats.max.retention.time` should not have 
been changed since the introduction of the feature, as the operator must know 
its underlying systems to set its value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to