vishesh92 commented on code in PR #8321:
URL: https://github.com/apache/cloudstack/pull/8321#discussion_r1427866783


##########
engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java:
##########
@@ -110,7 +110,7 @@ public class ServiceOfferingVO implements ServiceOffering {
     private boolean defaultUse;
 
     @Column(name = "vm_type")
-    private String vmType;
+    private String systemVmType;

Review Comment:
   The field name should match the method name after `get` or `is`. The other 
option would be to change the method name. Otherwise the method interception 
fails.
   
   Ref. code:
   
https://github.com/apache/cloudstack/blob/de095ba70d2a2261ffb2db7f3b8f29544939028e/framework/db/src/main/java/com/cloud/utils/db/SearchBase.java#L477-L503



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to