weizhouapache commented on code in PR #7221:
URL: https://github.com/apache/cloudstack/pull/7221#discussion_r1427930836
##########
api/src/main/java/org/apache/cloudstack/api/command/user/backup/RestoreVolumeFromBackupAndAttachToVMCmd.java:
##########
@@ -73,6 +74,12 @@ public class RestoreVolumeFromBackupAndAttachToVMCmd extends
BaseAsyncCmd {
description = "id of the VM where to attach the restored volume")
private Long vmId;
+ @Parameter(name = ApiConstants.START_VM,
+ type = CommandType.BOOLEAN,
+ required = false,
+ description = "start VM after the restore is finished")
Review Comment:
@SadiJr
You can do lots of operations on vcenter or veeam, but cloudstack does not
support OOB operations perfectly.
We should avoid the OOB operations as much as possible, unless it is really
neccessary.
I think it is unnecessary to add the option. If you insist to support, I
would rather starting the vm by invoking cloudstack methods/API (as cloudstack
will check the proper host by available resources, affinity groups, and apply
network rules, etc), than starting the vm via veeam.
Let me give you an example, if you stop a vm, and the network is shutdown
(VR is stopped), when you start the vm in vcenter or veeam, the vm has no
internet connection as the VR is still stopped.
We have actually faced several issues caused by OOB operations
(start/migration), or DRS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
