weizhouapache commented on code in PR #8371:
URL: https://github.com/apache/cloudstack/pull/8371#discussion_r1432662763
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -2310,12 +2311,12 @@ public void releaseNic(final VirtualMachineProfile
vmProfile, final Nic nic) thr
@DB
protected void releaseNic(final VirtualMachineProfile vmProfile, final
long nicId) throws ConcurrentOperationException, ResourceUnavailableException {
- final Pair<Network, NicProfile> networkToRelease =
Transaction.execute(new TransactionCallback<Pair<Network, NicProfile>>() {
+ final Pair<Network, NicProfile> networkToRelease =
Transaction.execute(new TransactionCallback<>() {
@Override
public Pair<Network, NicProfile> doInTransaction(final
TransactionStatus status) {
final NicVO nic = _nicDao.lockRow(nicId, true);
if (nic == null) {
- throw new ConcurrentOperationException("Unable to acquire
lock on nic " + nic);
+ throw new
ConcurrentOperationException(String.format("Unable to acquire lock on nic
id==%d", nicId));
Review Comment:
double "="
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]