DaanHoogland commented on code in PR #8371:
URL: https://github.com/apache/cloudstack/pull/8371#discussion_r1434046832
##########
server/src/main/java/com/cloud/network/guru/ControlNetworkGuru.java:
##########
@@ -166,18 +167,25 @@ public boolean release(NicProfile nic,
VirtualMachineProfile vm, String reservat
assert nic.getTrafficType() == TrafficType.Control;
HypervisorType hType = vm.getHypervisorType();
if ( ( (hType == HypervisorType.VMware) || (hType ==
HypervisorType.Hyperv) )&& isRouterVm(vm)) {
+ // for now place this in the vmware specific part, but it miught
be more generic and move up two or three lines
+ if
(!VirtualNetworkApplianceManager.RemoveNicsOnStop.valueIn(vm.getVirtualMachine().getDataCenterId()))
{
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug(String.format("not releasing %s\n\t from
%s\n\t with reservationId %s.", nic, vm, reservationId));
Review Comment:
```suggestion
s_logger.debug(String.format("not releasing %s from %s
with reservationId %s.", nic, vm, reservationId));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
