sureshanaparti commented on code in PR #8377:
URL: https://github.com/apache/cloudstack/pull/8377#discussion_r1433478710
##########
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolUtil.java:
##########
@@ -517,7 +517,13 @@ public static SpApiResponse volumeUpdate(final String
name, final Long newSize,
return POST("MultiCluster/VolumeUpdate/" + name, json, conn);
}
- public static SpApiResponse volumeUpdateTags(final String name, final
String uuid, Long iops,
+ public static SpApiResponse volumeRemoveTags(String name, Map<String,
String> tags, SpConnectionDesc conn) {
+ Map<String, Object> json = new HashMap<>();
Review Comment:
@slavkap Better to create empty tags map here, instead of passing it to
indicate removal of tags in the method, otherwise it's like an update tags.
_Map<String, String> tags = StorPoolHelper.addStorPoolTags(null, "", null,
"");_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
