JoaoJandre commented on code in PR #8409:
URL: https://github.com/apache/cloudstack/pull/8409#discussion_r1438392628
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/agent/api/CreateNsxPortForwardRuleCommand.java:
##########
@@ -49,4 +51,18 @@ public long getRuleId() {
public String getProtocol() {
return protocol;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+ if (!super.equals(o)) return false;
Review Comment:
Same
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/agent/api/DeleteNsxNatRuleCommand.java:
##########
@@ -51,4 +53,18 @@ public String getPrivatePort() {
public String getProtocol() {
return protocol;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+ if (!super.equals(o)) return false;
Review Comment:
same
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/agent/api/DeleteNsxSegmentCommand.java:
##########
@@ -48,4 +50,18 @@ public long getNetworkId() {
public String getNetworkName() {
return networkName;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+ if (!super.equals(o)) return false;
Review Comment:
same
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/agent/api/DeleteNsxLoadBalancerRuleCommand.java:
##########
@@ -37,4 +38,18 @@ public long getLbId() {
}
public List<NsxLoadBalancerMember> getMemberList() { return memberList; }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+ if (!super.equals(o)) return false;
Review Comment:
same
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/agent/api/CreateNsxLoadBalancerRuleCommand.java:
##########
@@ -66,4 +67,18 @@ public String getAlgorithm() {
public String getProtocol() {
return protocol;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+ if (!super.equals(o)) return false;
Review Comment:
same
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/agent/api/DeleteNsxTier1GatewayCommand.java:
##########
@@ -41,4 +43,18 @@ public String getNetworkResourceName() {
public boolean isResourceVpc() {
return isResourceVpc;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+ if (!super.equals(o)) return false;
Review Comment:
same
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/agent/api/CreateNsxDhcpRelayConfigCommand.java:
##########
@@ -56,4 +57,18 @@ public String getNetworkName() {
public List<String> getAddresses() {
return addresses;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+ if (!super.equals(o)) return false;
+ CreateNsxDhcpRelayConfigCommand that =
(CreateNsxDhcpRelayConfigCommand) o;
Review Comment:
```suggestion
if (this == o) {
return true;
}
if (o == null || getClass() != o.getClass() || !super.equals(o)) {
return false;
}
CreateNsxDhcpRelayConfigCommand that =
(CreateNsxDhcpRelayConfigCommand) o;
```
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/agent/api/CreateOrUpdateNsxTier1NatRuleCommand.java:
##########
@@ -47,4 +49,18 @@ public String getTranslatedIpAddress() {
public String getNatRuleId() {
return natRuleId;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+ if (!super.equals(o)) return false;
Review Comment:
same
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/agent/api/CreateNsxDistributedFirewallRulesCommand.java:
##########
@@ -46,4 +47,18 @@ public long getNetworkId() {
public List<NsxNetworkRule> getRules() {
return rules;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+ if (!super.equals(o)) return false;
Review Comment:
Same suggestion about code blocks that should follow the project's
conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
