gpordeus opened a new pull request, #8464: URL: https://github.com/apache/cloudstack/pull/8464
### Description An ICMP ACL rule should not be able to have code and type null. This PR fixes an edge case, that can be reproduced by: - Creating a VPC and an ACL. - Creating a TCP rule. - Calling the API with `updateNetworkACLItem` and parameters `protocol=icmp`, `partialupgrade=false`, `cidrlist=""` and `traffictype=ingress`. It will then set the rule with null ICMP code and type and the VR will face problems. This PR just extends the validation made when `partialupgrade` is false. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI ### Feature/Enhancement Scale or Bug Severity #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? By following the steps mentioned in the description: - With `protocol=icmp`, code and type became -1. - With `protocol=tcp` and `protocol=all`, the rule was changed and the attributes were reset accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
