Pearl1594 commented on code in PR #8465:
URL: https://github.com/apache/cloudstack/pull/8465#discussion_r1445111837
##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -855,7 +855,8 @@ private Pair<DiskProfile, StoragePool>
importDisk(UnmanagedInstanceTO.Disk disk,
}
private NicProfile importNic(UnmanagedInstanceTO.Nic nic, VirtualMachine
vm, Network network, Network.IpAddresses ipAddresses, int deviceId, boolean
isDefaultNic, boolean forced) throws
InsufficientVirtualNetworkCapacityException,
InsufficientAddressCapacityException {
- Pair<NicProfile, Integer> result =
networkOrchestrationService.importNic(nic.getMacAddress(), deviceId, network,
isDefaultNic, vm, ipAddresses, forced);
+ DataCenterVO dataCenterVO =
dataCenterDao.findById(network.getDataCenterId());
+ Pair<NicProfile, Integer> result =
networkOrchestrationService.importNic(nic.getMacAddress(), deviceId, network,
isDefaultNic, vm, ipAddresses, dataCenterVO, forced);
Review Comment:
Do we need to pass the entire object or can we just used the datacenterId
from the network? because in importNic method too , we only need the datacenter
id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
