GutoVeronezi commented on code in PR #8502:
URL: https://github.com/apache/cloudstack/pull/8502#discussion_r1450506118
##########
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##########
@@ -596,6 +596,7 @@ protected AgentAttache notifyMonitorsOfConnection(final
AgentAttache attache, fi
final Long dcId = host.getDataCenterId();
final ReadyCommand ready = new ReadyCommand(dcId, host.getId(),
NumbersUtil.enableHumanReadableSizes);
+ ready.setWait(60);
Review Comment:
In general, hard coded "magic" numbers are not interesting; we bind the
system to what we think is proper and do not allow the operators to shape the
system according to their use case.
For the timeout/wait settings, we could think on a flexible mecanism to
allow operators overriding the timeout/wait values in a granular way, e.g.
defining a timeout/wait for each command, and fallbacking to the global setting
`wait` in the absence of the specifc setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
