weizhouapache commented on code in PR #8502:
URL: https://github.com/apache/cloudstack/pull/8502#discussion_r1452031315


##########
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##########
@@ -596,6 +596,7 @@ protected AgentAttache notifyMonitorsOfConnection(final 
AgentAttache attache, fi
 
         final Long dcId = host.getDataCenterId();
         final ReadyCommand ready = new ReadyCommand(dcId, host.getId(), 
NumbersUtil.enableHumanReadableSizes);
+        ready.setWait(60);

Review Comment:
   @DaanHoogland @GutoVeronezi 
   I understand there are some operations which can take long time (migration, 
snapshots, etc), or some intervals (for background tasks, etc) which operators 
want to change.
   However, for these two commands which should be processed in less than 1 
second, what's the benefit of adding a new setting ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to