DaanHoogland commented on code in PR #8502:
URL: https://github.com/apache/cloudstack/pull/8502#discussion_r1452063797
##########
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##########
@@ -596,6 +596,7 @@ protected AgentAttache notifyMonitorsOfConnection(final
AgentAttache attache, fi
final Long dcId = host.getDataCenterId();
final ReadyCommand ready = new ReadyCommand(dcId, host.getId(),
NumbersUtil.enableHumanReadableSizes);
+ ready.setWait(60);
Review Comment:
the number of global setting we already have should not be an argument.
Nobody know them by head and anybody will have to use search facilities to
manage those anyway. We have not the value 60 in three separate extra places
for a value that has a default of 1800 (?). Both tuning and code maintenance
are served by creating an externalisation for those.
@weizhouapache I understand your argument against the need for tuning,
however we are now setting 60 for a value that you say should be one. That
sounds like we will want to tune it to 10 or 5 or maybe to 7 afterwards.
Anyway, this is merged. Let's discuss on #8506.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
