weizhouapache commented on PR #8520: URL: https://github.com/apache/cloudstack/pull/8520#issuecomment-1898632361
> I believe that metrics monitoring should work without operators having to worry about configurations and enabling/disabling the feature. Changing the configuration value from '60' to '0' compromised the functionality for the KVM hypervisor; which in turn, can make it seem as it does not work out of the box. An example of this is operators lacking visibility regarding the necessity of adding this configuration in the agent.properties file (see: [#8453 (comment)](https://github.com/apache/cloudstack/issues/8453#issuecomment-1880120221)). > In my opinion, the wrong memory usage is not a critical issue for operators. I believe most cloud operators use automation tools (chef, ansible, puppet, etc). It is very easy to apply the changes on all kvm hosts. > From my perspective, using the value '60' resolves issues similar to those faced by @shaerul in #8453. What are the main impacts you foresee with this change? As I said, I have faced an issue in the past. I am not sure if the issue was caused by windows virtio drivers or qemu/libvirt. anyway, we do not need to make decision for users. There is already a configuration for users to enable/disable it or set to a different value. > > Regarding the issue encountered during the migration of a Windows instance with the memory balloon enabled ([#8453 (comment)](https://github.com/apache/cloudstack/issues/8453#issuecomment-1880956758)), could you explain the error scenario in detail? This would allow me to attempt to reproduce locally and, if necessary, extend this PR to address the issue related to the migration of Windows VMs with the memory balloon feature enabled. I do not remember the details very clearly. the kvm host is Ubuntu 18 or 20 the issue was difficult to reproduce, it happened to some vms with virtio drivers, large memory and memory intensive applications. but I am sure it was caused by memory stat, because the issue is gone after disabling memory stat on Windows vms. cc @RodrigoDLopez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
