vishesh92 commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1463528354
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java:
##########
@@ -55,8 +57,12 @@
import javax.inject.Inject;
import java.util.List;
-public class DefaultHostListener implements HypervisorHostListener {
+public class DefaultHostListener implements HypervisorHostListener,
Configurable {
private static final Logger s_logger =
Logger.getLogger(DefaultHostListener.class);
+ ConfigKey<Integer> ModifyStoragePoolCommandWait = new
ConfigKey<Integer>("Advanced", Integer.class,
+ "modify.storage.pool.command.wait", "60",
+ "Time in seconds to wait for ModifyStoragePoolCommand command to
return", true);
Review Comment:
I agree with you. But generic config might not work. e.g.
`storage.command.wait` as 60 seconds will work for `ModifyStoragePoolCommand`
but not might be appropriate for other storage related commands. It needs to be
specific to a `Command`.
IMO, it would be better to have something which allows the user to set
configuration if required like `command.<command name>.wait` and wait is set
only if the value is set. If it's not set, then some default value is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
