BryanMLima commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1906484675

   > clgtm, and lots of test. Just a thought; an integration test seems 
appropriate for such a profoundly user facing feature, would you say 
@BryanMLima ?
   
   @DaanHoogland, got back after the holidays, and looking back, I don't think 
it needs integration tests. Mainly because there is no interaction with other 
APIs. The `quotaPresetVariableList` API was created to help users create custom 
Quota tariffs. Before this API, one would need to keep and maintain a document 
with the allowed preset variables. With this change, there is an API that is 
always updated when any changes are made in the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to