kohrar commented on PR #8560: URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1909652043
> > > @sureshanaparti this is based on main so I changed the milestone to 4.20. @kohrar if you wnat this in 4.18.2 please `git rebase --onto 4.18 <current base> <head>` cc @JoaoJandre > > > > > > @DaanHoogland Thanks. I didn't realize I targetted main. I'll keep that in mind in the future. I've created a new PR (#8564) that targets 4.18. Is this the correct approach? > > We don't have to create two PRs for two branches @kohrar. You can simply rebase this current branch with 4.18 (or force push to add_missing_en_locale) and change the apache:main to apache:4.18 in this PR itself. 😅 Thanks for the pointer. It took me a little too long to figure out how to change the PR to target 4.18 on GitHub. I hope that I got it right now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
