vishesh92 commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1466669536


##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java:
##########
@@ -121,7 +122,9 @@ private NicTO createNicTOFromNetworkAndOffering(NetworkVO 
networkVO, NetworkOffe
     public boolean hostConnect(long hostId, long poolId) throws 
StorageConflictException {
         StoragePool pool = (StoragePool) 
this.dataStoreMgr.getDataStore(poolId, DataStoreRole.Primary);
         ModifyStoragePoolCommand cmd = new ModifyStoragePoolCommand(true, 
pool);
-        cmd.setWait(60);
+        cmd.setWait(Wait.value() / 5);

Review Comment:
   It's more about the worst case scenario. It will wait for the specified time 
only if the agent is stuck because of some reason. Before #8502, if the wait 
was set to 18000, this command would have waited for 10 hours (5 hours *2). 
This solution doesn't completely solve the the problem but reduces the issues 
to some extent until issues #8506 or #8011 is resolved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to