GutoVeronezi commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1466747036
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java:
##########
@@ -121,7 +122,9 @@ private NicTO createNicTOFromNetworkAndOffering(NetworkVO
networkVO, NetworkOffe
public boolean hostConnect(long hostId, long poolId) throws
StorageConflictException {
StoragePool pool = (StoragePool)
this.dataStoreMgr.getDataStore(poolId, DataStoreRole.Primary);
ModifyStoragePoolCommand cmd = new ModifyStoragePoolCommand(true,
pool);
- cmd.setWait(60);
+ cmd.setWait(Wait.value() / 5);
Review Comment:
In contrast with taking a value and dividing it by a random number,
externalizing a new configuration would be the best option. We will not
externalize every command timeout right now, so it would not be a problem. I
agree a more robust solution, like what I mentioned in
https://github.com/apache/cloudstack/pull/8502#discussion_r1450506118, is
better; however, we have to discuss it first.
As last resort, if you do not want to externalize a new configuration,
creating a constant with javadoc for this case is better than deriving the
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
