DaanHoogland commented on code in PR #8230:
URL: https://github.com/apache/cloudstack/pull/8230#discussion_r1474330612


##########
server/src/main/java/com/cloud/usage/UsageServiceImpl.java:
##########
@@ -213,10 +212,10 @@ public Pair<List<? extends Usage>, Integer> 
getUsageRecords(ListUsageRecordsCmd
         Date adjustedStartDate = computeAdjustedTime(startDate, usageTZ);
         Date adjustedEndDate = computeAdjustedTime(endDate, usageTZ);
 
-        if (s_logger.isDebugEnabled()) {
-            s_logger.debug("getting usage records for account: " + accountId + 
", domainId: " + domainId + ", between " + adjustedStartDate + " and " + 
adjustedEndDate +
-                ", using pageSize: " + cmd.getPageSizeVal() + " and 
startIndex: " + cmd.getStartIndex());
-        }
+        s_logger.debug(String.format("Getting usage records for account ID 
[%s], domain ID [%s] between [%s] and [%s] using page size [%s] and start index 
[%s].",

Review Comment:
   please don't remove those guards yet. we can remove those when parameter 
evaluation is no longer happening.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to