GutoVeronezi commented on code in PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#discussion_r1479648472
##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffListCmd.java:
##########
@@ -46,19 +46,19 @@ public class QuotaTariffListCmd extends BaseListCmd {
@Parameter(name = ApiConstants.USAGE_TYPE, type = CommandType.INTEGER,
description = "Usage type of the resource")
private Integer usageType;
- @Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
description = "The start date of the quota tariff. Use yyyy-MM-dd as the date
format, "
- + "e.g. startDate=2009-06-03.")
+ @Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
description = "The start date of the quota tariff. " +
+ ApiConstants.PARAMETER_DESCRIPTION_START_DATE_POSSIBLE_FORMATS)
private Date effectiveDate;
- @Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "The end date of the quota tariff. Use yyyy-MM-dd as the date
format, e.g. "
- + "endDate=2021-11-03.", since = "4.18.0.0")
+ @Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "The end date of the quota tariff. " +
+ ApiConstants.PARAMETER_DESCRIPTION_END_DATE_POSSIBLE_FORMATS)
private Date endDate;
- @Parameter(name = ApiConstants.NAME, type = CommandType.STRING,
description = "The name of the quota tariff.", since = "4.18.0.0")
+ @Parameter(name = ApiConstants.NAME, type = CommandType.STRING,
description = "The name of the quota tariff.")
Review Comment:
Why remove `since`?
##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffUpdateCmd.java:
##########
@@ -52,8 +52,8 @@ public class QuotaTariffUpdateCmd extends BaseCmd {
"Use yyyy-MM-dd as the date format, e.g. startDate=2009-06-03.")
private Date startDate;
- @Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "The end date of the quota tariff. Use yyyy-MM-dd as the date
format, e.g."
- + " endDate=2009-06-03.", since = "4.18.0.0")
+ @Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "The end date of the quota tariff. " +
Review Comment:
Why remove `since`?
##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffListCmd.java:
##########
@@ -46,19 +46,19 @@ public class QuotaTariffListCmd extends BaseListCmd {
@Parameter(name = ApiConstants.USAGE_TYPE, type = CommandType.INTEGER,
description = "Usage type of the resource")
private Integer usageType;
- @Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
description = "The start date of the quota tariff. Use yyyy-MM-dd as the date
format, "
- + "e.g. startDate=2009-06-03.")
+ @Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
description = "The start date of the quota tariff. " +
+ ApiConstants.PARAMETER_DESCRIPTION_START_DATE_POSSIBLE_FORMATS)
private Date effectiveDate;
- @Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "The end date of the quota tariff. Use yyyy-MM-dd as the date
format, e.g. "
- + "endDate=2021-11-03.", since = "4.18.0.0")
+ @Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "The end date of the quota tariff. " +
+ ApiConstants.PARAMETER_DESCRIPTION_END_DATE_POSSIBLE_FORMATS)
private Date endDate;
- @Parameter(name = ApiConstants.NAME, type = CommandType.STRING,
description = "The name of the quota tariff.", since = "4.18.0.0")
+ @Parameter(name = ApiConstants.NAME, type = CommandType.STRING,
description = "The name of the quota tariff.")
private String name;
- @Parameter(name = ApiConstants.LIST_ALL, type = CommandType.BOOLEAN,
description = "False will list only not removed quota tariffs. If set to True,
we will "
- + "list all, including the removed ones. The default is false.",
since = "4.18.0.0")
+ @Parameter(name = ApiConstants.LIST_ALL, type = CommandType.BOOLEAN,
description = "False will list only not removed quota tariffs. If set to true,
we will "
Review Comment:
Why remove `since`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
