DaanHoogland commented on code in PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#discussion_r1480209735
##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffListCmd.java:
##########
@@ -46,19 +46,19 @@ public class QuotaTariffListCmd extends BaseListCmd {
@Parameter(name = ApiConstants.USAGE_TYPE, type = CommandType.INTEGER,
description = "Usage type of the resource")
private Integer usageType;
- @Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
description = "The start date of the quota tariff. Use yyyy-MM-dd as the date
format, "
- + "e.g. startDate=2009-06-03.")
+ @Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
description = "The start date of the quota tariff. " +
+ ApiConstants.PARAMETER_DESCRIPTION_START_DATE_POSSIBLE_FORMATS)
private Date effectiveDate;
- @Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "The end date of the quota tariff. Use yyyy-MM-dd as the date
format, e.g. "
- + "endDate=2021-11-03.", since = "4.18.0.0")
+ @Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "The end date of the quota tariff. " +
+ ApiConstants.PARAMETER_DESCRIPTION_END_DATE_POSSIBLE_FORMATS)
Review Comment:
good catch by @GutoVeronezi , here as well, please do not remove the since
attribute of the annotation. It could be helpful to some.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
