weizhouapache commented on PR #8647: URL: https://github.com/apache/cloudstack/pull/8647#issuecomment-1941761480
> > PR #7417's main purpose was to introduce the concept. > > I know, or better I remember now ;) > > > The idea was to create the new files as we would change the views; however, there is no problem in creating them right away. > > In hindsight it might be a bit confusing and lead to review errors . I'll get myself in an agry streak soon and add the rest. @DaanHoogland @GutoVeronezi IMHO, ideally the database upgrade process should be - drop procedures if exist, and create procedures - perform database upgrade scripts (in .sql files) and data migration (in .java files), which should not depend on views - create views #7417 has introduced the concept to create views as last step, which is good. however, we should also consider - recreating all views might take quite long time if the database if huge - the upgrade script or data migration might rely on some views (need double-check) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
