(cloudstack) 02/02: NSX: Cleanup PF rule associated to an expunged VM

[pearl11594]

This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a commit to branch fr03-cleanup-PF-udp-lb
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 702a2cb2d4b2f666e2b64c33f7d2ad612ff6f82f
Author: Pearl Dsilva <pearl1...@gmail.com>
AuthorDate: Thu Feb 22 11:40:30 2024 -0500

    NSX: Cleanup PF rule associated to an expunged VM
---
 .../nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java    | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
 
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
index 76e28d59c9f..f69cc0d1bef 100644
--- 
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
+++ 
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
@@ -535,8 +535,7 @@ public class NsxElement extends AdapterBase implements  
DhcpServiceProvider, Dns
         for (PortForwardingRule rule : rules) {
             IPAddressVO publicIp = 
ApiDBUtils.findIpAddressById(rule.getSourceIpAddressId());
             UserVm vm = ApiDBUtils.findUserVmById(rule.getVirtualMachineId());
-            if ((vm == null && (rule.getState() != FirewallRule.State.Revoke)) 
||
-                    (vm != null && networkModel.getNicInNetwork(vm.getId(), 
network.getId()) == null)) {
+            if (vm == null && rule.getState() != FirewallRule.State.Revoke) {
                 continue;
             }
             NsxOpObject nsxObject = getNsxOpObject(network);