andrijapanicsb commented on code in PR #8721: URL: https://github.com/apache/cloudstack/pull/8721#discussion_r1505906655
########## ui/public/locales/en.json: ########## @@ -2845,7 +2845,7 @@ "message.remove.vpc": "Please confirm that you want to remove the VPC", "message.request.failed": "Request failed.", "message.required.add.least.ip": "Please add at least 1 IP Range", -"message.required.traffic.type": "All required traffic types should be added and with multiple physical networks each network should have a label.", +"message.required.traffic.type": "All required traffic types should be added and with multiple physical networks each traffic type should have a label.", Review Comment: If we stick to the grammar wording (should (don't have to) vs. must (have to)) - then yes. The problem was that it said each network should have a label, while actually, traffic types are having labels (not networks) - that is why this change is there @DaanHoogland See this comment (where this comes from https://github.com/apache/cloudstack/pull/8625#issuecomment-1955115729 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
