sureshanaparti commented on code in PR #8726:
URL: https://github.com/apache/cloudstack/pull/8726#discussion_r1507117502
##########
usage/src/main/java/com/cloud/usage/UsageManagerImpl.java:
##########
@@ -983,34 +984,38 @@ private boolean parseHelperTables(AccountVO account, Date
currentStartDate, Date
private void createHelperRecord(UsageEventVO event) {
String eventType = event.getType();
- if (isVMEvent(eventType)) {
- createVMHelperEvent(event);
- } else if (isIPEvent(eventType)) {
- createIPHelperEvent(event);
- } else if (isVolumeEvent(eventType)) {
- createVolumeHelperEvent(event);
- } else if (isTemplateEvent(eventType)) {
- createTemplateHelperEvent(event);
- } else if (isISOEvent(eventType)) {
- createISOHelperEvent(event);
- } else if (isSnapshotEvent(eventType)) {
- createSnapshotHelperEvent(event);
- } else if (isLoadBalancerEvent(eventType)) {
- createLoadBalancerHelperEvent(event);
- } else if (isPortForwardingEvent(eventType)) {
- createPortForwardingHelperEvent(event);
- } else if (isNetworkOfferingEvent(eventType)) {
- createNetworkOfferingEvent(event);
- } else if (isVPNUserEvent(eventType)) {
- handleVpnUserEvent(event);
- } else if (isSecurityGroupEvent(eventType)) {
- createSecurityGroupEvent(event);
- } else if (isVmSnapshotEvent(eventType)) {
- handleVMSnapshotEvent(event);
- } else if (isVmSnapshotOnPrimaryEvent(eventType)) {
- createVmSnapshotOnPrimaryEvent(event);
- } else if (isBackupEvent(eventType)) {
- createBackupEvent(event);
+ try {
+ if (isVMEvent(eventType)) {
+ createVMHelperEvent(event);
+ } else if (isIPEvent(eventType)) {
+ createIPHelperEvent(event);
+ } else if (isVolumeEvent(eventType)) {
+ createVolumeHelperEvent(event);
+ } else if (isTemplateEvent(eventType)) {
+ createTemplateHelperEvent(event);
+ } else if (isISOEvent(eventType)) {
+ createISOHelperEvent(event);
+ } else if (isSnapshotEvent(eventType)) {
+ createSnapshotHelperEvent(event);
+ } else if (isLoadBalancerEvent(eventType)) {
+ createLoadBalancerHelperEvent(event);
+ } else if (isPortForwardingEvent(eventType)) {
+ createPortForwardingHelperEvent(event);
+ } else if (isNetworkOfferingEvent(eventType)) {
+ createNetworkOfferingEvent(event);
+ } else if (isVPNUserEvent(eventType)) {
+ handleVpnUserEvent(event);
+ } else if (isSecurityGroupEvent(eventType)) {
+ createSecurityGroupEvent(event);
+ } else if (isVmSnapshotEvent(eventType)) {
+ handleVMSnapshotEvent(event);
+ } else if (isVmSnapshotOnPrimaryEvent(eventType)) {
+ createVmSnapshotOnPrimaryEvent(event);
+ } else if (isBackupEvent(eventType)) {
+ createBackupEvent(event);
+ }
+ } catch (EntityExistsException e) {
+ s_logger.error(String.format("Failed to create usage event: %d due
to %s", event.getId(), e.getMessage()));
Review Comment:
can add _eventType_ to log, and error => warn ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
