weizhouapache commented on code in PR #8791:
URL: https://github.com/apache/cloudstack/pull/8791#discussion_r1526044811
##########
ui/src/utils/plugins.js:
##########
@@ -490,8 +499,7 @@ export const genericUtilPlugin = {
}
app.config.globalProperties.$toBase64AndURIEncoded = function (text) {
- const base64regex =
/^([0-9a-zA-Z+/]{4})*(([0-9a-zA-Z+/]{2}==)|([0-9a-zA-Z+/]{3}=))?$/
- if (base64regex.test(text)) {
+ if (isBase64(text)) {
Review Comment:
@Pearl1594
thanks for the update.
with your latest change, do we still need this ?
```
if (isBase64(text)) {
return text
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]