SadiJr commented on code in PR #8765:
URL: https://github.com/apache/cloudstack/pull/8765#discussion_r1528951434
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2578,7 +2579,13 @@ protected void finalizeNetworkRulesForNetwork(final
Commands cmds, final DomainR
}
}
- final List<LoadBalancerVO> lbs =
_loadBalancerDao.listByNetworkIdAndScheme(guestNetworkId, Scheme.Public);
+ List<LoadBalancerVO> lbs = null;
+ Long vpcId = guestNetwork.getVpcId();
+ if (vpcId != null) {
+ lbs = _loadBalancerDao.listByVpcIdAndScheme(vpcId,
Scheme.Public);
Review Comment:
Correct, the method is indeed called for each guest network, but the
`LoadBalancerConfigCommand` command, from what I've analyzed in the logs, is
not the same. Instead, for each guest network that calls such a method, only
the load balancer rules for that network are passed in the
`LoadBalancerConfigCommand` command. This is the reason why, in a VPC with
multiple guest networks, each of which has its own load balancer rules, only
the rules of the last implemented network are applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
