weizhouapache commented on code in PR #8809:
URL: https://github.com/apache/cloudstack/pull/8809#discussion_r1533414679
##########
server/src/main/java/com/cloud/consoleproxy/AgentHookBase.java:
##########
@@ -213,7 +213,7 @@ public void startAgentHttpHandlerInVM(StartupProxyCommand
startupCmd) {
byte[] ksBits = null;
String consoleProxyUrlDomain =
_configDao.getValue(Config.ConsoleProxyUrlDomain.key());
- String consoleProxySslEnabled =
_configDao.getValue("consoleproxy.sslEnabled");
+ String consoleProxySslEnabled =
_configDao.getValue(ConsoleProxyManager.ConsoleProxySslEnabled.key());
Review Comment:
I did some debugging, it looks the values are the same.
```
2024-03-21T08:05:48,498 DEBUG [c.c.c.ConsoleProxyManagerImpl] (main:[])
(logid:) configs.get(ConsoleProxySslEnabled.key() = true
2024-03-21T08:05:48,502 DEBUG [c.c.c.ConsoleProxyManagerImpl] (main:[])
(logid:) ConsoleProxySslEnabled.value() = true
2024-03-21T08:06:02,499 DEBUG [c.c.c.C.VmBasedAgentHook]
(AgentConnectTaskPool-4:[ctx-f64d74cc]) (logid:29169184)
_configDao.getValue(ConsoleProxyManager.ConsoleProxySslEnabled.key()) = true
2024-03-21T08:06:02,499 DEBUG [c.c.c.C.VmBasedAgentHook]
(AgentConnectTaskPool-4:[ctx-f64d74cc]) (logid:29169184)
ConsoleProxySslEnabled.value() = true
```
however, I prefer not to change the code as the old/new codes basically get
the same value from database.
The old code has been proved to be working. Some other values are fetched in
the same way.
@GutoVeronezi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
