weizhouapache commented on code in PR #8813:
URL: https://github.com/apache/cloudstack/pull/8813#discussion_r1537163766
##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -2252,7 +2255,7 @@ private UserVm importKvmVirtualMachineFromDisk(final
ImportSource importSource,
UserVm userVm = null;
Map<String, String> allDetails = new HashMap<>(details);
- if (serviceOffering.isDynamic()) {
+ if (!serviceOffering.isDynamic()) {
allDetails.put(VmDetailConstants.CPU_NUMBER,
String.valueOf(serviceOffering.getCpu()));
Review Comment:
@vishesh92
it is different from what I thought: if service offering is not dynamic, the
CPU and Memory are fixed and no need to add record to user_vm_details for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
