DaanHoogland commented on code in PR #8811:
URL: https://github.com/apache/cloudstack/pull/8811#discussion_r1537421147
##########
plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java:
##########
@@ -965,6 +981,36 @@ private Answer copyTemplate(DataObject srcData, DataObject
dstData) {
return answer;
}
+ private Answer copyVolume(DataObject srcData, DataObject dstData) {
+ VolumeInfo srcVolInfo = (VolumeInfo) srcData;
+ final StoragePoolVO pool =
_storagePoolDao.findById(srcVolInfo.getDataStore().getId());
+ final DevelopersApi api =
LinstorUtil.getLinstorAPI(pool.getHostAddress());
+ final String rscName = LinstorUtil.RSC_PREFIX + srcVolInfo.getUuid();
+
+ int nMaxExecutionMinutes = NumbersUtil.parseInt(
+
_configDao.getValue(Config.SecStorageCmdExecutionTimeMax.key()), 30);
Review Comment:
default for `SecStorageCmdExecutionTimeMax` is 30 minutes.
default for `CopyVolumeWait` is 10800 secs (180 minutes)
by the name of your method `CopyVolumeWait` seems more appropriate, but you
could even create your own var (or use either)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
