1561316811 commented on issue #8854: URL: https://github.com/apache/cloudstack/issues/8854#issuecomment-2040961656
Firstly, as we can see, in the following link. we know the "log.trace" need to log out "cleanedCommands", a sensitive variable but masked "password". So we infer "log.trace" cannot log out the sensitive data. https://github.com/apache/cloudstack/blob/2959cc67652381e3a39b298e674a0bced5002337/plugins/outofbandmanagement-drivers/ipmitool/src/main/java/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolWrapper.java#L175 Secondly, in the following link, we know the "job" is a sensitive variable, that needs to be masked before logging out. https://github.com/apache/cloudstack/blob/2959cc67652381e3a39b298e674a0bced5002337/framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java#L637 Lastly, in the following link, we can see the "job" was logged out by "log.trace" without masked. https://github.com/apache/cloudstack/blob/2959cc67652381e3a39b298e674a0bced5002337/framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java#L647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
