vishesh92 commented on code in PR #8915:
URL: https://github.com/apache/cloudstack/pull/8915#discussion_r1565495355
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -2969,7 +2969,10 @@ protected void
setVAppPropertiesToConfigSpec(VmConfigInfo vAppConfig,
}
private String appendFileType(String path, String fileType) {
- if (path.toLowerCase().endsWith(fileType.toLowerCase())) {
+ if (path == null) {
+ throw new CloudRuntimeException("No path given, cannot append
filetype" + fileType);
+ }
+ if (fileType = null ||
path.toLowerCase().endsWith(fileType.toLowerCase())) {
Review Comment:
```suggestion
if (fileType == null ||
path.toLowerCase().endsWith(fileType.toLowerCase())) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
