DaanHoogland commented on code in PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#discussion_r1568782998


##########
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/store/TemplateObject.java:
##########
@@ -373,10 +380,7 @@ public String getInstallPath() {
 
     @Override
     public boolean isDirectDownload() {
-        if (this.imageVO == null) {
-            return false;
-        }
-        return this.imageVO.isDirectDownload();
+        return getImage().isDirectDownload();

Review Comment:
   ```suggestion
           try {
               return getImage().isDirectDownload();
           } catch (InvalidParameterValueException e) {
               return false;
           }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to