DaanHoogland commented on code in PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#discussion_r1568778603
##########
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/store/TemplateObject.java:
##########
@@ -76,11 +78,16 @@ public class TemplateObject implements TemplateInfo {
TemplateDataStoreDao templateStoreDao;
final private boolean followRedirects;
- public TemplateObject() {
+ private TemplateObject() {
this.followRedirects =
StorageManager.DataStoreDownloadFollowRedirects.value();
}
protected void configure(VMTemplateVO template, DataStore dataStore) {
+ if (template == null) {
+ String msg = String.format("Template Object is not properly
initialised %s", this.toString());
+ s_logger.error(msg);
+ throw new InvalidParameterValueException(msg);
+ }
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
