rohityadavcloud commented on code in PR #8940:
URL: https://github.com/apache/cloudstack/pull/8940#discussion_r1570710244
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -222,9 +222,7 @@ public String toString() {
guestDef.append("<boot dev='" + bo + "'/>\n");
}
}
- if (_arch == null || !_arch.equals("aarch64")) {
- guestDef.append("<smbios mode='sysinfo'/>\n");
- }
+ guestDef.append("<smbios mode='sysinfo'/>\n");
Review Comment:
Thanks to @weizhouapache for point out the dmidecode issue; after the fix
the arm64 guest instance returns this:
```
ubuntu@test-ubuntu:~$ sudo dmidecode
# dmidecode 3.3
Getting SMBIOS data from sysfs.
SMBIOS 3.0.0 present.
Table at 0x5FEC0000.
Handle 0x0100, DMI type 1, 27 bytes
System Information
Manufacturer: Apache Software Foundation
Product Name: CloudStack KVM Hypervisor
Version: virt-8.2
Serial Number: Not Specified
UUID: aafbca09-5d8a-4794-814e-d3380dbe31a9
Wake-up Type: Power Switch
SKU Number: Not Specified
Family: Not Specified
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
