GaOrtiga commented on code in PR #8934:
URL: https://github.com/apache/cloudstack/pull/8934#discussion_r1572296935
##########
engine/components-api/src/main/java/com/cloud/resource/ResourceManager.java:
##########
@@ -61,6 +61,11 @@ public interface ResourceManager extends ResourceService,
Configurable {
+ "To force-stop VMs, choose 'ForceStop' strategy",
true, ConfigKey.Scope.Global, null, null, null, null, null,
ConfigKey.Kind.Select, "Error,Migration,ForceStop");
+ ConfigKey<String> SystemVMDefaultHypervisor = new
ConfigKey<String>(String.class,
+ "system.vm.default.hypervisor", "Advanced", "Any", "Hypervisor
type used to create System VMs. Valid values are: XenServer, KVM, VMware,
Hyperv, VirtualBox, " +
+ "Parralels, BareMetal, Ovm, LXC, Any", true,
ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.Select,
"XenServer, KVM, VMware, Hyperv, " +
+ "VirtualBox, Parralels, BareMetal, Ovm, LXC, Any");
Review Comment:
@sureshanaparti I agree with changing the scope to zone, however, can you
further explain what you mean by handling "defaultSystemVMHypervisorType" in
upgrade?
Wouldn't changing the scope to zone and fetching the value of the config for
the specific zone be sufficient to guarantee the expected behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
